Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repository tests #163

Merged
merged 7 commits into from
Apr 12, 2024
Merged

Fix repository tests #163

merged 7 commits into from
Apr 12, 2024

Conversation

Tostti
Copy link
Member

@Tostti Tostti commented Apr 5, 2024

Description

Fix repository tests

Issues Resolved

#162

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.24%. Comparing base (e32d695) to head (1891888).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##           4.9.0-2.13.0     #163   +/-   ##
=============================================
  Coverage         67.24%   67.24%           
=============================================
  Files              3335     3335           
  Lines             64596    64596           
  Branches          10331    10331           
=============================================
+ Hits              43437    43439    +2     
+ Misses            18650    18649    -1     
+ Partials           2509     2508    -1     
Flag Coverage Δ
Linux_2 55.39% <ø> (ø)
Linux_3 44.71% <ø> (+<0.01%) ⬆️
Windows_1 31.33% <ø> (ø)
Windows_2 55.36% <ø> (ø)
Windows_3 44.71% <ø> (ø)
Windows_4 35.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tostti Tostti changed the title Update snapshots Fix repository tests Apr 8, 2024
@Tostti Tostti linked an issue Apr 8, 2024 that may be closed by this pull request
@Tostti Tostti self-assigned this Apr 8, 2024
@Tostti Tostti marked this pull request as ready for review April 8, 2024 18:10
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it would be good to add some commentary on what is being taken out so that in future synchronisation we don't have to do too much research on the changes.

Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tostti Tostti merged commit 18efe34 into 4.9.0-2.13.0 Apr 12, 2024
66 checks passed
@Tostti Tostti deleted the fix-repo-tests branch April 12, 2024 20:15
yenienserrano pushed a commit that referenced this pull request Jun 18, 2024
yenienserrano pushed a commit that referenced this pull request Jul 12, 2024
yenienserrano pushed a commit that referenced this pull request Aug 19, 2024
yenienserrano pushed a commit that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix repository tests
3 participants